Page MenuHomePhabricator
Differential D2748

Add schnorr sign benchmark
ClosedPublic
Actions

Authored by florian on Mar 27 2019, 23:42.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING5ea73621a21f: Add schnorr sign benchmark
rABC5ea73621a21f: Add schnorr sign benchmark
Summary

As per title.

Depends on D2747.

Test Plan

./bench_sign

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

florian created this revision.Mar 27 2019, 23:42
Owners added a reviewer: Restricted Owners Package.Mar 27 2019, 23:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2019, 23:42
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a comment.Mar 27 2019, 23:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 27 2019, 23:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5319: Diff 7850.Mar 27 2019, 23:57
Fabien requested changes to this revision.Mar 28 2019, 10:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/secp256k1/src/bench_sign.c
12 ↗(On Diff #7850)

nit: remove space between # and include

This revision now requires changes to proceed.Mar 28 2019, 10:35
florian updated this revision to Diff 7895.Apr 2 2019, 01:40

Remove extra space.

teamcity added a comment.Apr 2 2019, 01:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 2 2019, 01:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5348: Diff 7895.Apr 2 2019, 01:55
Fabien accepted this revision as: Fabien.Apr 2 2019, 14:59
jasonbcox accepted this revision.Apr 2 2019, 19:01
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/secp256k1/src/bench_sign.c
58 ↗(On Diff #7895)

Looks like the constant can be applied here as well :) See this comment: https://reviews.bitcoinabc.org/D2749#inline-16991

This revision is now accepted and ready to land.Apr 2 2019, 19:01
Closed by commit rABC5ea73621a21f: Add schnorr sign benchmark (authored by florian). · Explain WhyApr 2 2019, 22:38
This revision was automatically updated to reflect the committed changes.
florian added a commit: rSTAGING5ea73621a21f: Add schnorr sign benchmark.Sep 19 2019, 14:55

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
24 lines

Diff 7926

View Options

src/secp256k1/src/bench_sign.c

Loading...