Page MenuHomePhabricator

Add schnorr sign benchmark
ClosedPublic

Authored by florian on Mar 27 2019, 23:42.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING5ea73621a21f: Add schnorr sign benchmark
rABC5ea73621a21f: Add schnorr sign benchmark
Summary

As per title.

Depends on D2747.

Test Plan

./bench_sign

Diff Detail

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 27 2019, 23:42
Fabien requested changes to this revision.Mar 28 2019, 10:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/secp256k1/src/bench_sign.c
12 ↗(On Diff #7850)

nit: remove space between # and include

This revision now requires changes to proceed.Mar 28 2019, 10:35
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/secp256k1/src/bench_sign.c
58

Looks like the constant can be applied here as well :) See this comment: https://reviews.bitcoinabc.org/D2749#inline-16991

This revision is now accepted and ready to land.Apr 2 2019, 19:01
This revision was automatically updated to reflect the committed changes.