Page MenuHomePhabricator
Differential D2749

Add schnorr verify benchmark
ClosedPublic
Actions

Authored by florian on Mar 28 2019, 00:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8dfaa2198450: Add schnorr verify benchmark
rABC8dfaa2198450: Add schnorr verify benchmark
Summary

As per title.

Depends on D2747.

Test Plan

./bench_verify

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bench_schnorr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5349
Build 8760: Bitcoin ABC Buildbot (legacy)
Build 8759: arc lint + arc unit

Event Timeline

florian created this revision.Mar 28 2019, 00:14
Owners added a reviewer: Restricted Owners Package.Mar 28 2019, 00:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 28 2019, 00:14
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a comment.Mar 28 2019, 00:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 28 2019, 00:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5321: Diff 7852.Mar 28 2019, 00:29
Fabien requested changes to this revision.Mar 28 2019, 10:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/secp256k1/src/bench_verify.c
15 ↗(On Diff #7852)

nit: remove space between # and include

This revision now requires changes to proceed.Mar 28 2019, 10:34
florian updated this revision to Diff 7896.Apr 2 2019, 01:43

Remove extra space.

teamcity added a comment.Apr 2 2019, 01:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 2 2019, 01:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5349: Diff 7896.Apr 2 2019, 01:58
Fabien accepted this revision as: Fabien.Apr 2 2019, 14:59
jasonbcox accepted this revision.Apr 2 2019, 19:00
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/secp256k1/src/bench_verify.c
91

Idea for a future diff: make the 20000 a constant and use it throughout this test file.

This revision is now accepted and ready to land.Apr 2 2019, 19:00
Closed by commit rABC8dfaa2198450: Add schnorr verify benchmark (authored by florian). · Explain WhyApr 2 2019, 22:41
This revision was automatically updated to reflect the committed changes.
florian added a commit: rSTAGING8dfaa2198450: Add schnorr verify benchmark.Sep 19 2019, 14:55

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
28 lines

Diff 7896

View Options

src/secp256k1/src/bench_verify.c

Loading...