Page MenuHomePhabricator

Add schnorr verify benchmark
ClosedPublic

Authored by florian on Mar 28 2019, 00:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8dfaa2198450: Add schnorr verify benchmark
rABC8dfaa2198450: Add schnorr verify benchmark
Summary

As per title.

Depends on D2747.

Test Plan

./bench_verify

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bench_schnorr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5349
Build 8760: Bitcoin ABC Buildbot (legacy)
Build 8759: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 28 2019, 00:14
Fabien requested changes to this revision.Mar 28 2019, 10:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/secp256k1/src/bench_verify.c
15 ↗(On Diff #7852)

nit: remove space between # and include

This revision now requires changes to proceed.Mar 28 2019, 10:34
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/secp256k1/src/bench_verify.c
91

Idea for a future diff: make the 20000 a constant and use it throughout this test file.

This revision is now accepted and ready to land.Apr 2 2019, 19:00
This revision was automatically updated to reflect the committed changes.