Make sure we have one txdata object per tx we validate. That's required for parallel signature checking.
ClosedPublic
Actions

Authored by deadalnix on Jun 28 2017, 16:14.

Details

Reviewers

freetrader
sickpig
awemany
kyuupichan

Group Reviewers

Restricted Project

Commits

rSTAGINGe6cb027f5b08: Make sure we have one txdata object per tx we validate. That's required for…
rABCe6cb027f5b08: Make sure we have one txdata object per tx we validate. That's required for…

Summary

In case of parallel validation, we need to make sure we have one txdata object per transaction being validated, or they may end up stepping on each other's toes.

Test Plan

make check

Enable parallel validation. invalidate block 000000000002f96388721eefe2f3246577636902a7d2c9034ffc9731b1a154cf and then reconsider it. it is accepted. Run the manipulation several times to make sure.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 28 2017, 16:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2017, 16:14

Harbormaster completed remote builds in B435: Diff 707.Jun 28 2017, 16:14

Remove debugging leftovers

Harbormaster completed remote builds in B438: Diff 711.Jun 28 2017, 16:30

Accepted - this is a revert of 05fdbe78b and back to existing Core code .

src/validation.cpp
2404 ↗	(On Diff #707)	Suggest to remove once validated, or if want to retain this LogPrint, give it a more descriptive message, e.g. "invalid state: "