Page MenuHomePhabricator

Remove direct bitcoin calls from qt/optionsdialog.cpp
ClosedPublic

Authored by jasonbcox on Apr 24 2019, 00:01.

Details

Summary
Test Plan

ninja check
make check
bitcoin-qt # sanity checks; check options dialog

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5588
Build 9238: Bitcoin ABC Buildbot (legacy)
Build 9237: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Apr 25 2019, 17:52
Fabien added inline comments.
src/qt/optionsdialog.cpp
9 ↗(On Diff #8270)

Please fix ordering

This revision now requires changes to proceed.Apr 25 2019, 17:52

Fix include ordering for project headers

This revision is now accepted and ready to land.Apr 26 2019, 15:35
This revision was automatically updated to reflect the committed changes.