Page MenuHomePhabricator
Differential D2871

Remove direct bitcoin calls from qt/optionsdialog.cpp
ClosedPublic
Actions

Authored by jasonbcox on Apr 24 2019, 00:01.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING19a1f8da0135: Remove direct bitcoin calls from qt/optionsdialog.cpp
rABC19a1f8da0135: Remove direct bitcoin calls from qt/optionsdialog.cpp
Summary

Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/90d4640b7eff3154a0750c5acb52d39bd41e0bbb
Progress towards T417

Test Plan

ninja check
make check
bitcoin-qt # sanity checks; check options dialog

Diff Detail

Repository
rABC Bitcoin ABC
Branch
options
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5609
Build 9280: Bitcoin ABC Buildbot (legacy)
Build 9279: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 24 2019, 00:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2019, 00:01
teamcity added a comment.Apr 24 2019, 00:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 24 2019, 00:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5588: Diff 8254.Apr 24 2019, 00:17
jasonbcox added a child revision: D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.Apr 24 2019, 20:35
jasonbcox updated this revision to Diff 8270.Apr 25 2019, 15:51

Rebase

teamcity added a comment.Apr 25 2019, 15:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5598: Diff 8270.Apr 25 2019, 16:07
teamcity added a comment.Apr 25 2019, 16:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien requested changes to this revision.Apr 25 2019, 17:52
Fabien added inline comments.
src/qt/optionsdialog.cpp
9 ↗(On Diff #8270)

Please fix ordering

This revision now requires changes to proceed.Apr 25 2019, 17:52
jasonbcox updated this revision to Diff 8284.Apr 26 2019, 15:34

Fix include ordering for project headers

Fabien accepted this revision.Apr 26 2019, 15:35
This revision is now accepted and ready to land.Apr 26 2019, 15:35
teamcity added a comment.Apr 26 2019, 15:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 26 2019, 15:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5609: Diff 8284.Apr 26 2019, 15:50
Closed by commit rABC19a1f8da0135: Remove direct bitcoin calls from qt/optionsdialog.cpp (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyApr 26 2019, 21:57
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING19a1f8da0135: Remove direct bitcoin calls from qt/optionsdialog.cpp.Sep 18 2019, 23:09

Revision Contents
Changeset List

PathSize
src/
qt/
26 lines
4 lines

Diff 8284

View Options

src/qt/optionsdialog.cpp

Loading...
View Options

src/qt/optionsmodel.h

Loading...