Page MenuHomePhabricator

blockfilter: Refactor and add tests for BlockFilter construction
ClosedPublic

Authored by markblundeberg on Apr 24 2019, 05:18.

Details

Summary

This is a backport of core PR 14172
e4ed8ce2c blockfilter: Remove default clause in switch statement.
c30620983 blockfilter: Additional constructors for BlockFilter.
20b812993 blockfilter: Refactor GCS params into struct.

Depends on D2867

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14172
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5605
Build 9272: Bitcoin ABC Buildbot (legacy)
Build 9271: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Apr 25 2019, 09:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/blockfilter.cpp
104 ↗(On Diff #8255)

uint8_t

222 ↗(On Diff #8255)

dito

This revision now requires changes to proceed.Apr 25 2019, 09:09
markblundeberg marked 2 inline comments as done.

address Fabien comments

src/blockfilter.cpp
104 ↗(On Diff #8255)

Argh, I don't know how I missed that .. I thought I had caught them all!

This revision is now accepted and ready to land.Apr 30 2019, 13:05