Page MenuHomePhabricator
Differential D2879

blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter
ClosedPublic
Actions

Authored by markblundeberg on Apr 26 2019, 05:16.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Maniphest Tasks
T589: BIP157 & BIP158 backports
Commits
rSTAGINGf9ed1e8d3ff8: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the…
rABCf9ed1e8d3ff8: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the…
Summary

backport of core PR 15532 (commit 82c3b3f8e)

Note: due to BOOST_CHECK_EQUAL barfing on the new enum class uint8_t,
I've switched that test to also use just BOOST_CHECK.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15532
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5606
Build 9274: Bitcoin ABC Buildbot (legacy)
Build 9273: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Apr 26 2019, 05:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 26 2019, 05:16
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg added a task: T589: BIP157 & BIP158 backports.Apr 26 2019, 05:16
teamcity added a comment.Apr 26 2019, 05:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5606: Diff 8280.Apr 26 2019, 05:31
teamcity added a comment.Apr 26 2019, 05:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Apr 29 2019, 17:38
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/blockfilter_tests.cpp
131

I hope the ctor = constructor and ctor = canonical transaction order doesn't get confusing in the future... lol. context saves us in this instance.

This revision is now accepted and ready to land.Apr 29 2019, 17:38
Mengerian added a subscriber: Mengerian.May 4 2019, 17:03
Mengerian added inline comments.
src/test/blockfilter_tests.cpp
131

Would it be worth changing it to something unambiguous like default_constructor_block_filter?

Closed by commit rABCf9ed1e8d3ff8: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 4 2019, 17:51
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGf9ed1e8d3ff8: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the….Sep 18 2019, 23:14

Revision Contents
Changeset List

PathSize
src/
5 lines
2 lines
test/
12 lines

Diff 8280

View Options

src/blockfilter.h

Loading...
View Options

src/blockfilter.cpp

Loading...
View Options

src/test/blockfilter_tests.cpp

Loading...