Page MenuHomePhabricator

[LINTER] Move the string formatting function list to the python script
ClosedPublic

Authored by Fabien on Apr 26 2019, 15:51.

Details

Summary

This change the call stack when running the lint-format-strings.sh
linter. The python script is now called once per file instead of running
once per function per file. The python script does loop internally
resulting in a large performance improvement (about 80% time cut on my
machine).

Depends on D2881.

Test Plan
arc lint --everything

Should return no error

Comment one of the false positive at the beginning of the
lint-format-strings.py file.
Add a comment in the file from the commented false positive.

arc lint

The false positive should be catched by the linter.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lint_format_string_performance_improve_2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5611
Build 9284: Bitcoin ABC Buildbot (legacy)
Build 9283: arc lint + arc unit