Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/58845587e11140e81f087a74c3db76a4d1fc3a1a
Progress towards T417
Depends on D2886
Details
Details
- Reviewers
deadalnix Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGINGd80fb0a9f1e3: Remove direct bitcoin calls from qt transaction table files
rABCd80fb0a9f1e3: Remove direct bitcoin calls from qt transaction table files
make check
ninja check
bitcoin-qt # sanity checks on transaction details
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- txtable
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5620 Build 9302: Bitcoin ABC Buildbot (legacy) Build 9301: arc lint + arc unit
Event Timeline
| src/interfaces/wallet.cpp | ||
|---|---|---|
| 87 | You can use LookupBlockIndex() here. | |
| 268 | OK The lock is here. So maybe add an AssertLockHeld(cs_main) in MakeWalletTxStatus() ? | |
| src/qt/bitcoin.cpp | ||
| 28 | i comes befors q | |
| src/qt/recentrequeststablemodel.cpp | ||
| 5 | You updated the .h to angle brackets, don't you want to update the .cpp as well ? | |
| src/qt/recentrequeststablemodel.h | ||
| 8 | <qt/walletmodel.h> | |
| src/qt/transactiondesc.cpp | ||
| 7 | Please sort with the others for consistency | |
| src/qt/transactionrecord.cpp | ||
| 74 | Braces | |
| 75 | Dito | |
| 80 | Dito | |
| 81 | Dito | |
| src/qt/transactiontablemodel.cpp | ||
| 7 | Sort them with others for consistency | |
| src/interfaces/wallet.cpp | ||
|---|---|---|
| 87 | good idea. | |
| 268 | LookupBlockIndex already calls AssertLockHeld, so we're good. killed two birds with one stone :) | |
| src/qt/bitcoin.cpp | ||
| 28 | Looks like the #ifdef broke up the sorting. I'll move it down to its own section. | |
| src/qt/recentrequeststablemodel.cpp | ||
| 5 | Yes, thanks for flagging. | |