Page MenuHomePhabricator

Merge #11238: Add assertions before potential null deferences
ClosedPublic

Authored by jasonbcox on May 2 2019, 20:57.

Details

Summary

c00199244 Fix potential null dereferences (MeshCollider)

Pull request description:

Picked up by the static analyzer [Facebook Infer](http://fbinfer.com/) which I was playing around with for another research project. Just adding some asserts before dereferencing potentially null pointers.

Tree-SHA512: 9c01dab2d21bce75c7c7ef867236654ab538318a1fb39f96f09cdd2382a05be1a6b2db0a1169a94168864e82ffeae0686a383db6eba799742bdd89c37ac74397

Backport of Core PR 11238
https://github.com/bitcoin/bitcoin/pull/11238/files
Completes T627

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11238
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5653
Build 9368: Bitcoin ABC Buildbot (legacy)
Build 9367: arc lint + arc unit

Event Timeline

src/net_processing.cpp
357

The other missing change from the original PR was already backported out of order here: D1749

src/rpc/blockchain.cpp
930

The other missing change from the original PR was already backported out of order here: D954

This revision is now accepted and ready to land.May 4 2019, 00:24
This revision was automatically updated to reflect the committed changes.