Page MenuHomePhabricator
Differential D2929

Sanitize some wallet serialization
ClosedPublic
Actions

Authored by markblundeberg on May 5 2019, 17:01.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T635: Backport PR 12658 "Sanitize some wallet serialization"
Commits
rSTAGING9920930c59a8: Sanitize some wallet serialization
rABC9920930c59a8: Sanitize some wallet serialization
Summary

Backport of PR12658 https://github.com/bitcoin/bitcoin/pull/12658/files

42343c748 Split up and sanitize CAccountingEntry serialization (Pieter Wuille)
029ecac1b Split up and sanitize CWalletTx serialization (Pieter Wuille)

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12658
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5681
Build 9424: Bitcoin ABC Buildbot (legacy)
Build 9423: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 5 2019, 17:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2019, 17:01
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg added a task: T635: Backport PR 12658 "Sanitize some wallet serialization".May 5 2019, 17:01
teamcity added a comment.May 5 2019, 17:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg planned changes to this revision.May 5 2019, 17:02
markblundeberg updated this revision to Diff 8396.May 5 2019, 17:07

fix comment placement

teamcity added a comment.May 5 2019, 17:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 5 2019, 17:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5680: Diff 8395.May 5 2019, 17:16
teamcity added a comment.May 5 2019, 17:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5681: Diff 8396.May 5 2019, 17:22
markblundeberg added a child revision: D2932: Support serialization as another type without casting.May 5 2019, 18:07
markblundeberg added reviewers: jasonbcox, Fabien.May 7 2019, 00:41
jasonbcox accepted this revision.May 7 2019, 16:15
This revision is now accepted and ready to land.May 7 2019, 16:15
Closed by commit rABC9920930c59a8: Sanitize some wallet serialization (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 8 2019, 01:31
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING9920930c59a8: Sanitize some wallet serialization.Sep 18 2019, 23:20

Revision Contents
Changeset List

PathSize
src/
wallet/
121 lines

Diff 8396

View Options

src/wallet/wallet.h

Loading...