Page MenuHomePhabricator
Differential D2930

Merge READWRITEMANY into READWRITE
ClosedPublic
Actions

Authored by markblundeberg on May 5 2019, 17:51.

Details

Reviewers
deadalnix
Fabien
nakihito
Group Reviewers
Restricted Project
Maniphest Tasks
T634: Backport PR 12683 "Fix more constness violations in serialization code"
Commits
rSTAGING2a64216d4da6: Merge READWRITEMANY into READWRITE
rABC2a64216d4da6: Merge READWRITEMANY into READWRITE
Summary

Backported commit 1/2 (2761bca997) from PR12683

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12683a
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5682
Build 9426: Bitcoin ABC Buildbot (legacy)
Build 9425: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 5 2019, 17:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2019, 17:51
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg added a task: T634: Backport PR 12683 "Fix more constness violations in serialization code".May 5 2019, 17:51
teamcity added a comment.May 5 2019, 17:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5682: Diff 8397.May 5 2019, 18:06
teamcity added a comment.May 5 2019, 18:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg added a child revision: D2931: Support deserializing into temporaries.May 5 2019, 18:06
markblundeberg added a reviewer: Fabien.May 7 2019, 00:40
markblundeberg added a reviewer: nakihito.May 7 2019, 22:01
Fabien accepted this revision.May 9 2019, 07:01
This revision is now accepted and ready to land.May 9 2019, 07:01
Closed by commit rABC2a64216d4da6: Merge READWRITEMANY into READWRITE (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 9 2019, 15:51
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING2a64216d4da6: Merge READWRITEMANY into READWRITE.Sep 18 2019, 23:24

Revision Contents
Changeset List

PathSize
src/
24 lines
test/
2 lines

Diff 8397

View Options

src/serialize.h

Loading...
View Options

src/test/serialize_tests.cpp

Loading...