Page MenuHomePhabricator

Use C++14
AbandonedPublic

Authored by schancel on Jul 3 2017, 15:07.

Details

Reviewers
freetrader
sickpig
awemany
kyuupichan
deadalnix
Group Reviewers
Restricted Project
Summary

As per title.

Test Plan
make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cpp14
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 452
Build 452: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 3 2017, 15:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2017, 15:07
deadalnix updated this revision to Diff 733.Jul 3 2017, 15:08

Fix comment

Harbormaster completed remote builds in B452: Diff 733.Jul 3 2017, 15:08
freetrader edited edge metadata.EditedJul 3 2017, 20:18

This one needs to come with a travis.yml upgrade.

https://travis-ci.org/ftrader-bitcoinabc/bitcoin-abc/builds/249712288

Unless the plan is to ditch Travis and go with something else for CI.

I'll experiment a bit on that branch (https://github.com/ftrader-bitcoinabc/bitcoin-abc/commits/test_d294_require_cxx_14). So far, looks like we might need Travis support to even get it working despite their published instructions.

C++14 is already several years old.

CI on each patch is not important enough for it to be worth it. Many projects do not run CI on each patch and are doing just fine (LLVM being one of them). If a contributor keeps submitting patches that breaks the build, the right solution is to fire that contributor. Someone not testing his own patch is problem that CI on each patch can only hide, not fix.

First and foremost, we need CI on master.

freetrader added a comment.EditedJul 9 2017, 20:43

Ubuntu Yakkety (16.10) and Debian 9 come with g++ versions that are able to build with this C++14 requirement.
To properly support C++14, we need to upgrade the gitian build which currently uses Ubuntu 16.04 (Trusty).

OK I'll get that figured out. This can wait in the meantime, this is low pri.

deadalnix planned changes to this revision.Jul 9 2017, 21:10
schancel commandeered this revision.Feb 24 2018, 07:46
schancel abandoned this revision.
schancel added a reviewer: deadalnix.