Page MenuHomePhabricator

Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially referencing
ClosedPublic

Authored by jasonbcox on Tue, May 7, 21:41.

Details

Summary

c36ea69 [wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call. (Karl-Johan Alm)

Tree-SHA512: a14c9f3e1228bca91977bea821c56a377d80889b41d250050c9be67aa93e460319a7cf1d4b63ee40f23b5a34159590f0e3fe15dc88698dc694c0c8098bd2db4d

Backport of Core PR 10265
https://github.com/bitcoin/bitcoin/pull/10265/files

Completes T643
Depends on D2976

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Tue, May 7, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 7, 21:41
jasonbcox edited the summary of this revision. (Show Details)Tue, May 7, 21:42
jasonbcox planned changes to this revision.Tue, May 7, 21:45
jasonbcox edited the summary of this revision. (Show Details)Tue, May 7, 21:50
jasonbcox updated this revision to Diff 8478.Tue, May 7, 22:06

Rebase ontop of D2976

Also includes re-adding a code block because it conflicts with every single backport in this function.

I guess this description is out of date (now covered in parent diff)?

Fabien accepted this revision.Wed, May 8, 08:09
Fabien edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Wed, May 8, 08:11
This revision was automatically updated to reflect the committed changes.