Page MenuHomePhabricator
Differential D2974

Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially referencing
ClosedPublic
Actions

Authored by jasonbcox on May 7 2019, 21:41.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGeaa496a915de: Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially…
rABCeaa496a915de: Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially…
Summary

c36ea69 [wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call. (Karl-Johan Alm)

Tree-SHA512: a14c9f3e1228bca91977bea821c56a377d80889b41d250050c9be67aa93e460319a7cf1d4b63ee40f23b5a34159590f0e3fe15dc88698dc694c0c8098bd2db4d

Backport of Core PR 10265
https://github.com/bitcoin/bitcoin/pull/10265/files

Completes T643
Depends on D2976

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10265-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5739
Build 9540: Bitcoin ABC Buildbot (legacy)
Build 9539: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 7 2019, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 21:41
jasonbcox edited the summary of this revision. (Show Details)May 7 2019, 21:42
teamcity added a comment.May 7 2019, 21:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox planned changes to this revision.May 7 2019, 21:45
jasonbcox edited the summary of this revision. (Show Details)May 7 2019, 21:50
jasonbcox added a parent revision: D2976: Revert removal of code block.
teamcity added a comment.May 7 2019, 21:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5735: Diff 8474.May 7 2019, 21:56
jasonbcox updated this revision to Diff 8478.May 7 2019, 22:06

Rebase ontop of D2976

teamcity added a comment.May 7 2019, 22:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 7 2019, 22:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5739: Diff 8478.May 7 2019, 22:21
jasonbcox added a child revision: D2979: Merge #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime.May 7 2019, 22:59
markblundeberg added a subscriber: markblundeberg.May 7 2019, 23:06

Also includes re-adding a code block because it conflicts with every single backport in this function.

I guess this description is out of date (now covered in parent diff)?

Fabien accepted this revision.May 8 2019, 08:09
Fabien edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.May 8 2019, 08:11
Closed by commit rABCeaa496a915de: Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 8 2019, 18:13
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGeaa496a915de: Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially….Sep 18 2019, 23:21

Revision Contents
Changeset List

PathSize
src/
wallet/
14 lines

Diff 8478

View Options

src/wallet/wallet.cpp

Loading...