Revert removal of code block
ClosedPublic
Actions

Authored by jasonbcox on May 7 2019, 21:49.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING54ac1d870374: Revert removal of code block
rABC54ac1d870374: Revert removal of code block

Summary

Reverts the removal of a code block in D301 that is making backporting difficult and adds little value otherwise.

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

scope

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5737
Build 9536: Bitcoin ABC Buildbot (legacy)
Build 9535: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 7 2019, 21:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 21:49

jasonbcox added a child revision: D2974: Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially referencing.May 7 2019, 21:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5737: Diff 8476.May 7 2019, 22:04

"useless scopes" but in fact they do have a use: allowing easy backports =D

Fabien accepted this revision.May 8 2019, 08:09

This revision is now accepted and ready to land.May 8 2019, 08:09

Closed by commit rABC54ac1d870374: Revert removal of code block (authored by jasonbcox). · Explain WhyMay 8 2019, 16:52

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING54ac1d870374: Revert removal of code block.Sep 18 2019, 23:21

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

97 lines

Diff 8476

View Options

Revert removal of code blockClosedPublicActions