Page MenuHomePhabricator
Differential D2999

Merge #10126: Compensate for memory peak at flush time
ClosedPublic
Actions

Authored by jasonbcox on May 8 2019, 23:06.

Details

Reviewers
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING7bd410c3c230: Merge #10126: Compensate for memory peak at flush time
rABC7bd410c3c230: Merge #10126: Compensate for memory peak at flush time
Summary

7228ce8 Compensate for memory peak at flush time (Pieter Wuille)

Tree-SHA512: 97e9848410fab061402c85d8440c54a50dd8a0203b2ea194013ea116700a6dc1b4b26b8c5f9c9c68c1f5c6b935c5d6c737437c1911b003d9ff5445c570cd449d

Backport of Core PR10126
https://github.com/bitcoin/bitcoin/pull/10126/files

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 8 2019, 23:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2019, 23:06
teamcity added a comment.May 8 2019, 23:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 8 2019, 23:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5768: Diff 8532.May 8 2019, 23:21
jasonbcox edited the summary of this revision. (Show Details)May 9 2019, 00:16
markblundeberg accepted this revision.May 9 2019, 01:15
markblundeberg added a subscriber: markblundeberg.

Seems like quite some follow-ups have occured to this:
https://github.com/bitcoin/bitcoin/pull/10133
https://github.com/bitcoin/bitcoin/pull/11022

This revision is now accepted and ready to land.May 9 2019, 01:15
jasonbcox added a comment.May 9 2019, 19:30

Thanks for the links. I'll look into them.

Closed by commit rABC7bd410c3c230: Merge #10126: Compensate for memory peak at flush time (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 9 2019, 19:32
This revision was automatically updated to reflect the committed changes.
jasonbcox added a comment.May 9 2019, 19:43

For posterity: both of those PRs have already been backported.

jasonbcox added a reverting change: D3007: Revert "Merge #10126: Compensate for memory peak at flush time".May 9 2019, 19:43
jasonbcox added a reverting change: rABCb809b0250876: Revert "Merge #10126: Compensate for memory peak at flush time".May 10 2019, 01:09
jasonbcox added a commit: rSTAGING7bd410c3c230: Merge #10126: Compensate for memory peak at flush time.Sep 18 2019, 23:27
jasonbcox added a reverting change: rSTAGINGb809b0250876: Revert "Merge #10126: Compensate for memory peak at flush time".

Revision Contents
Changeset List

PathSize
src/
3 lines

Diff 8567

View Options

src/validation.cpp

Loading...