Page MenuHomePhabricator
Differential D3024

[tests] Remove unused variables
ClosedPublic
Actions

Authored by nakihito on May 10 2019, 22:09.

Details

Reviewers
jasonbcox
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGfb6518323802: [tests] Remove unused variables
rABCfb6518323802: [tests] Remove unused variables
Summary

[tests] Remove unused variables

Backport of Core PR10047
https://github.com/bitcoin/bitcoin/pull/10047/
Commit 2/2

Depends on D3023

Test Plan
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10047-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5812
Build 9686: Bitcoin ABC Buildbot (legacy)
Build 9685: arc lint + arc unit

Event Timeline

nakihito created this revision.May 10 2019, 22:09
Owners added a reviewer: Restricted Owners Package.May 10 2019, 22:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 10 2019, 22:09
teamcity added a comment.May 10 2019, 22:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 10 2019, 22:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5812: Diff 8609.May 10 2019, 22:24
deadalnix requested changes to this revision.May 12 2019, 23:29

Where is part 1 ? Why doesn't this depends on part 1 ?

Also fix the test plan so command appear like command, prefixed with 2 spaces.

This revision now requires changes to proceed.May 12 2019, 23:29
nakihito edited the summary of this revision. (Show Details)EditedMay 13 2019, 00:10
nakihito added a parent revision: D3023: [tests] Remove unused and duplicate imports.

Sorry, I must've forgotten to put the dependency in. Added now. Will fix the test plan later tonight.

nakihito edited the summary of this revision. (Show Details)May 13 2019, 17:14
nakihito edited the test plan for this revision. (Show Details)
nakihito requested review of this revision.May 15 2019, 01:00
Fabien accepted this revision.May 16 2019, 15:00
deadalnix accepted this revision.May 16 2019, 15:50
This revision is now accepted and ready to land.May 16 2019, 15:50
Closed by commit rABCfb6518323802: [tests] Remove unused variables (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by nakihito). · Explain WhyMay 17 2019, 17:59
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGfb6518323802: [tests] Remove unused variables.Sep 18 2019, 23:35

Revision Contents
Changeset List

PathSize
test/
functional/
1 line
1 line
2 lines

Diff 8609

View Options

test/functional/rpc_fundrawtransaction.py

Loading...
View Options

test/functional/rpc_rawtransaction.py

Loading...
View Options

test/functional/rpc_users.py

Loading...