Merge #10280: [test] Unit test amount.h/amount.cpp
ClosedPublic
Actions

Authored by nakihito on May 13 2019, 19:38.

Details

Reviewers

deadalnix
jasonbcox
Fabien
markblundeberg

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa9cd88bfcd32: Merge #10280: [test] Unit test amount.h/amount.cpp
rABCa9cd88bfcd32: Merge #10280: [test] Unit test amount.h/amount.cpp

Summary

dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

Backport of Core PR10280
https://github.com/bitcoin/bitcoin/pull/10280

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10280

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5836
Build 9734: Bitcoin ABC Buildbot (legacy)
Build 9733: arc lint + arc unit

Event Timeline

nakihito created this revision.May 13 2019, 19:38

Owners added a reviewer: Restricted Owners Package.May 13 2019, 19:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2019, 19:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5836: Diff 8640.May 13 2019, 19:53

nakihito edited the summary of this revision. (Show Details)May 14 2019, 00:37

Re-added full constructor comment.

Harbormaster completed remote builds in B5839: Diff 8645.May 14 2019, 00:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

nakihito edited the test plan for this revision. (Show Details)May 14 2019, 01:50

Fabien accepted this revision.May 14 2019, 06:10

This revision is now accepted and ready to land.May 14 2019, 06:10

Closed by commit rABCa9cd88bfcd32: Merge #10280: [test] Unit test amount.h/amount.cpp (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyMay 14 2019, 16:56

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGa9cd88bfcd32: Merge #10280: [test] Unit test amount.h/amount.cpp.Sep 18 2019, 23:31

Revision Contents
Changeset List

Path

Size

src/

test/

amount_tests.cpp

28 lines

feerate_tests.cpp

8 lines

Diff 8640

View Options

src/test/amount_tests.cpp