Page MenuHomePhabricator
Differential D3058

Have gArgs handle printing help
ClosedPublic
Actions

Authored by deadalnix on May 16 2019, 16:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING7254fd799a0b: Have gArgs handle printing help
rABC7254fd799a0b: Have gArgs handle printing help
Summary

This is a remake of Core PR13190 . Because the parameter set we have differs from core, I ended up having to redo most of it, even though the ogic is the same.

Test Plan
make check
arc lint

Make sure that the doc linter is still happy.

BUILDDIR=~/bitcoin-abc/build ../contrib/devtools/gen-manpages.sh

Make sure, that even though some arguments have been shuffled around, the doc is still good.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
paramrefacmanual
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5873
Build 9806: Bitcoin ABC Buildbot (legacy)
Build 9805: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 16 2019, 16:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2019, 16:15
teamcity added a comment.May 16 2019, 16:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 16 2019, 16:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5873: Diff 8699.May 16 2019, 16:30
Fabien accepted this revision.May 16 2019, 18:13
This revision is now accepted and ready to land.May 16 2019, 18:13
Closed by commit rABC7254fd799a0b: Have gArgs handle printing help (authored by deadalnix). · Explain WhyMay 16 2019, 22:03
This revision was automatically updated to reflect the committed changes.
nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jun 12 2019, 23:30
nakihito mentioned this in D3382: Merge #10088: Trivial: move several relay options into the relay help group.Jun 21 2019, 19:00
deadalnix added a commit: rSTAGING7254fd799a0b: Have gArgs handle printing help.Sep 18 2019, 23:35
PiRK mentioned this in D8105: remove redundant strprintf and add missing sentence in doc.Oct 25 2020, 07:15
PiRK mentioned this in rABCd4280f43d3d2: remove redundant strprintf and add missing sentence in doc.Oct 25 2020, 16:10

Revision Contents
Changeset List

PathSize
src/
bench/
80 lines
93 lines
120 lines
8 lines
5 lines
18 lines
10 lines
988 lines
interfaces/
5 lines
4 lines
qt/
46 lines
39 lines
30 lines
52 lines
wallet/
156 lines
2 lines
test/
lint/
2 lines

Diff 8699

View Options

src/bench/bench_bitcoin.cpp

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/bitcoind.cpp

Loading...
View Options

src/chainparamsbase.h

Loading...
View Options

src/chainparamsbase.cpp

Loading...
View Options

src/init.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/utilitydialog.cpp

Loading...
View Options

src/util.h

Loading...
View Options

src/util.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/walletinitinterface.h

Loading...
View Options

test/lint/check-doc.py

Loading...