Page MenuHomePhabricator
Differential D305

Read in consensus defaults.
ClosedPublic
Actions

Authored by freetrader on Jul 9 2017, 14:41.

Details

Reviewers
deadalnix
sickpig
kyuupichan
awemany
Group Reviewers
Restricted Project
Commits
rSTAGING6df5c9ce02d8: Read in consensus defaults.
rABC6df5c9ce02d8: Read in consensus defaults.
Summary

Now that we have a get_srcdir() utility function,
we can determine the location of consensus.h more reliably.

Avoids duplication of these default definitions.

Test Plan

../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_cdefs_reading_from_consensus
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 471
Build 471: arc lint + arc unit

Event Timeline

freetrader created this revision.Jul 9 2017, 14:41
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJul 9 2017, 14:41
Harbormaster completed remote builds in B471: Diff 759.Jul 9 2017, 14:41
deadalnix accepted this revision.Jul 9 2017, 18:19
deadalnix added inline comments.
qa/rpc-tests/test_framework/cdefs.py
31

Don't use eval. Parse the int.

This revision is now accepted and ready to land.Jul 9 2017, 18:19
Closed by commit rABC6df5c9ce02d8: Read in consensus defaults. (authored by freetrader, committed by freetrader). · Explain WhyJul 9 2017, 20:12
This revision was automatically updated to reflect the committed changes.
freetrader added inline comments.Jul 11 2017, 10:04
qa/rpc-tests/test_framework/cdefs.py
35 ↗(On Diff #763)

Going to change this one to use int parsing.

31

Parsing the int would work for DEFAULT_UAHF_START_TIME, but not for DEFAULT_MAX_BLOCK_SIZE unless we change the C++ definition to an integer instead of the expression 8 * ONE_MEGABYTE.

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
test_framework/
25 lines

Diff 759

View Options

qa/rpc-tests/test_framework/cdefs.py

Loading...