Merge #12182: Remove useless string initializations
ClosedPublic
Actions

Authored by nakihito on May 17 2019, 20:22.

Details

Reviewers

jasonbcox
deadalnix
Fabien
markblundeberg

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING7cb2951d02ce: Merge #12182: Remove useless string initializations
rABC7cb2951d02ce: Merge #12182: Remove useless string initializations

Summary

19ac86e Remove useless string initialization. (Alin Rus)

Pull request description:

Tree-SHA512: 4273dd7e8ed083cc9d05fc70967465e405085b630c000f829648dd44dd0cfe2249f6af1498b02f54b4ca73833130b802488bae8eca0d4d0b803a6f0122b19e8f

Backport of Core PR12182
https://github.com/bitcoin/bitcoin/pull/12182/

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12182

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5888
Build 9836: Bitcoin ABC Buildbot (legacy)
Build 9835: arc lint + arc unit

Event Timeline

nakihito created this revision.May 17 2019, 20:22

Owners added a reviewer: Restricted Owners Package.May 17 2019, 20:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 17 2019, 20:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5888: Diff 8726.May 17 2019, 20:37

Fabien accepted this revision.May 18 2019, 05:16

This revision is now accepted and ready to land.May 18 2019, 05:16

Closed by commit rABC7cb2951d02ce: Merge #12182: Remove useless string initializations (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyMay 20 2019, 21:11

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING7cb2951d02ce: Merge #12182: Remove useless string initializations.Sep 18 2019, 23:37

Revision Contents
Changeset List

Path

Size

src/

netbase.cpp

2 lines

rest.cpp

2 lines

test/

net_tests.cpp

2 lines

utilstrencodings.cpp

4 lines

wallet/

rpcdump.cpp

4 lines

Diff 8726

View Options

src/netbase.cpp

View Options

src/rest.cpp

View Options

src/test/net_tests.cpp

View Options

src/utilstrencodings.cpp

View Options

Merge #12182: Remove useless string initializationsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8726

src/netbase.cpp

src/rest.cpp

src/test/net_tests.cpp

src/utilstrencodings.cpp

src/wallet/rpcdump.cpp

Merge #12182: Remove useless string initializations
ClosedPublic
Actions

Revision Contents
Changeset List