Differential D3113

Comments: More comments on functions/globals in standard.h.
ClosedPublic
Actions

Authored by deadalnix on May 25 2019, 15:00.

Tags

None

Subscribers

Details

Reviewers

Mengerian
markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGING1f2a6d15575b: Comments: More comments on functions/globals in standard.h.
rABC1f2a6d15575b: Comments: More comments on functions/globals in standard.h.

Summary

Backport of Core PR11058

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 25 2019, 15:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2019, 15:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5985: Diff 8877.May 25 2019, 15:15

Looks good to me. I checked it against the core PR, and current Core code.

This revision is now accepted and ready to land.May 25 2019, 16:22

markblundeberg requested changes to this revision.May 25 2019, 16:57

markblundeberg added a subscriber: markblundeberg.

markblundeberg added inline comments.

src/script/standard.h
85 ↗	(On Diff #8877)	this doesn't match PR

This revision now requires changes to proceed.May 25 2019, 16:57

markblundeberg added inline comments.May 25 2019, 16:58

src/script/standard.h
75 ↗	(On Diff #8877)	intentional?
75 ↗	(On Diff #8877)	oh nvm

ah changed my mind, it's fine :)

This revision is now accepted and ready to land.May 25 2019, 17:00

Mengerian added inline comments.May 25 2019, 17:40

src/script/standard.h
85 ↗	(On Diff #8877)	Looks like it was missed in this previous backport: https://reviews.bitcoinabc.org/D540 https://github.com/bitcoin/bitcoin/pull/11117/files

markblundeberg added inline comments.May 25 2019, 18:06

src/script/standard.h
85 ↗	(On Diff #8877)	Yep, good find. :)

Fabien added a subscriber: Fabien.May 25 2019, 18:17

Fabien added inline comments.

src/script/standard.h
119 ↗	(On Diff #8877)	The last line can be removed

Closed by commit rABC1f2a6d15575b: Comments: More comments on functions/globals in standard.h. (authored by jimpo, committed by deadalnix). · Explain WhyMay 26 2019, 10:13

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC1f2a6d15575b: Comments: More comments on functions/globals in standard.h..

deadalnix added a commit: rSTAGING1f2a6d15575b: Comments: More comments on functions/globals in standard.h..Sep 18 2019, 23:45

Revision Contents
Changeset List

Path

Size

src/

script/

52 lines

4 lines

Diff 8880

src/script/standard.h

Loading...

src/script/standard.cpp

Loading...