Page MenuHomePhabricator

Comments: More comments on functions/globals in standard.h.
ClosedPublic

Authored by deadalnix on May 25 2019, 15:00.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
stddoc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5985
Build 10029: Bitcoin ABC Buildbot (legacy)
Build 10028: arc lint + arc unit

Event Timeline

Mengerian added a subscriber: Mengerian.

Looks good to me. I checked it against the core PR, and current Core code.

This revision is now accepted and ready to land.May 25 2019, 16:22
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
src/script/standard.h
85

this doesn't match PR

This revision now requires changes to proceed.May 25 2019, 16:57
src/script/standard.h
75

intentional?

75

oh nvm

ah changed my mind, it's fine :)

This revision is now accepted and ready to land.May 25 2019, 17:00
src/script/standard.h
85
src/script/standard.h
85

Yep, good find. :)

Fabien added inline comments.
src/script/standard.h
119

The last line can be removed