Page MenuHomePhabricator
Differential D3131

Use GetKeyForDestination in various RPCs
ClosedPublic
Actions

Authored by deadalnix on May 27 2019, 16:02.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING6c60601ce0bb: Use GetKeyForDestination in various RPCs
rABC6c60601ce0bb: Use GetKeyForDestination in various RPCs
Summary

This backports elements of Core PR11403:

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
swrpc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6017
Build 10093: Bitcoin ABC Buildbot (legacy)
Build 10092: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 27 2019, 16:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2019, 16:02
teamcity added a comment.May 27 2019, 16:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B6017: Diff 8930!May 27 2019, 16:23
teamcity added a comment.May 27 2019, 16:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix added a child revision: D3133: SegWit wallet support.May 27 2019, 18:31
deadalnix updated this revision to Diff 8938.May 27 2019, 21:49

Rebase

teamcity added a comment.May 27 2019, 21:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6024: Diff 8938.May 27 2019, 22:03
teamcity added a comment.May 27 2019, 22:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg accepted this revision.May 27 2019, 22:07
markblundeberg added a subscriber: markblundeberg.

ok build fail looks unrelated; tried on my end too and it's good.

This seems to be faithful to the original commit's intent and should be equivalent behaviour.

This revision is now accepted and ready to land.May 27 2019, 22:07
Closed by commit rABC6c60601ce0bb: Use GetKeyForDestination in various RPCs (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyMay 27 2019, 22:54
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC6c60601ce0bb: Use GetKeyForDestination in various RPCs.
deadalnix added a commit: rSTAGING6c60601ce0bb: Use GetKeyForDestination in various RPCs.Sep 18 2019, 23:49

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines
wallet/
6 lines

Diff 8930

View Options

src/rpc/util.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...