Page MenuHomePhabricator
Differential D3142

remove chain.h dependency from txdb.h
ClosedPublic
Actions

Authored by markblundeberg on May 28 2019, 16:11.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING705360aa0176: remove chain.h dependency from txdb.h
rABC705360aa0176: remove chain.h dependency from txdb.h
Summary

The forward declaration of CBlockIndex is already in here and sufficient.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nochain2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6038
Build 10135: Bitcoin ABC Buildbot (legacy)
Build 10134: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 28 2019, 16:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2019, 16:11
markblundeberg mentioned this in D2938: index: Move index DBs into index/ directory..May 28 2019, 16:12
teamcity added a comment.May 28 2019, 16:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added inline comments.May 28 2019, 16:14
src/txdb.h
20

(here)

teamcity added a comment.May 28 2019, 16:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6038: Diff 8970.May 28 2019, 16:26
jasonbcox accepted this revision.May 28 2019, 16:29
This revision is now accepted and ready to land.May 28 2019, 16:29
Closed by commit rABC705360aa0176: remove chain.h dependency from txdb.h (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 28 2019, 18:23
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC705360aa0176: remove chain.h dependency from txdb.h.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING705360aa0176: remove chain.h dependency from txdb.h.Sep 18 2019, 23:52

Revision Contents
Changeset List

PathSize
src/
index/
2 lines
test/
1 line
1 line
1 line

Diff 8970

View Options

src/index/txindex.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/txdb.h

Loading...
View Options

src/txdb.cpp

Loading...