Page MenuHomePhabricator
Differential D3205

Merge #11683: tests: Remove unused mininode functions {ser,deser}_int_vector(...). Remove unused imports.
ClosedPublic
Actions

Authored by nakihito on Jun 4 2019, 23:01.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGb1190c4fa726: Merge #11683: tests: Remove unused mininode functions {ser,deser}_int_vector(...
rABCb1190c4fa726: Merge #11683: tests: Remove unused mininode functions {ser,deser}_int_vector(...
Summary

f522fb7c9 tests: Remove unused mininode functions deser_int_vector(f) and ser_int_vector(l) (practicalswift)

Pull request description:

  • Remove unused mininode functions deser_int_vector(f) and ser_int_vector(l). Last use removed in 3858aabbd084b2cc4534c40a178bbcc22fb82968. Friendly ping @jnewbery :-)
  • Remove unused imports.

Tree-SHA512: 840c5623eae9f929561f6e86816883c5904ec1af82fc8d5e56dee1c0b1fe22e8600c10f7358ed8b556b3aec8c65c4910f6eee30e8015a573c4df8bef91124d3e

Backport of Core PR11683
https://github.com/bitcoin/bitcoin/pull/11683/commits/f522fb7c9c121641ce552774e3993942106ec336

This PR actually had two commits, but the second commit (0f3b752ec Remove unused imports (practicalswift)) was blank after fixing merge conflicts.

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11683
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6149
Build 10346: Bitcoin ABC Buildbot (legacy)
Build 10345: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 4 2019, 23:01
Owners added a reviewer: Restricted Owners Package.Jun 4 2019, 23:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2019, 23:01
teamcity added a comment.Jun 4 2019, 23:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Jun 4 2019, 23:14
jasonbcox edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 4 2019, 23:14
Harbormaster completed remote builds in B6149: Diff 9136.Jun 4 2019, 23:15
teamcity added a comment.Jun 4 2019, 23:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCb1190c4fa726: Merge #11683: tests: Remove unused mininode functions {ser,deser}_int_vector(... (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyJun 5 2019, 00:33
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCb1190c4fa726: Merge #11683: tests: Remove unused mininode functions {ser,deser}_int_vector(....
markblundeberg mentioned this in T469: Backport Core PR11683.Jul 7 2019, 17:16
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGb1190c4fa726: Merge #11683: tests: Remove unused mininode functions {ser,deser}_int_vector(....Sep 19 2019, 00:01

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
15 lines

Diff 9136

View Options

test/functional/test_framework/messages.py

Loading...