Page MenuHomePhabricator

Update URL for website and source code
ClosedPublic

Authored by deadalnix on Jul 13 2017, 21:13.

Details

Reviewers
freetrader
dagurval
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc40c59a79406: Update URL for website and source code
rABCc40c59a79406: Update URL for website and source code
Test Plan

Manual testing (open qt app, view about dialog)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
url-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 517
Build 517: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jul 13 2017, 21:13
deadalnix requested changes to this revision.Jul 13 2017, 22:09
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/init.cpp
1 ↗(On Diff #800)

Please fix.

This revision now requires changes to proceed.Jul 13 2017, 22:09

The stupid part is that I have a diff for this, but forgot to diff out :)

src/init.cpp
1 ↗(On Diff #800)

You want me to reformat the whole file together with this tiny change?

The file is already formatted.

dagurval edited edge metadata.

ran 'arc lint'

What version of clang format do you have on you computer ? This was already formatted so it is kind of weird that get that many changes.

deadalnix requested changes to this revision.Jul 14 2017, 10:04
This revision now requires changes to proceed.Jul 14 2017, 10:04

What version of clang format do you have on you computer ? This was already formatted so it is kind of weird that get that many changes.

$ clang-format --version
clang-format version 5.0.0 (tags/google/stable/2017-06-22)

I can install 3.8 instead if that helps

@dagurval :

I noticed on BU that clang-format from 5.x formats differently .

Use clang-format-3.8 - it works compatibly with BU and ABC .

dagurval edited edge metadata.

ran 'arc lint' with clang-format 3.8

Manually tested, looks ok to me.

This revision is now accepted and ready to land.Jul 14 2017, 23:34
deadalnix edited reviewers, added: dagurval; removed: deadalnix.
This revision was automatically updated to reflect the committed changes.