Page MenuHomePhabricator
Differential D322

Update URL for website and source code
ClosedPublic
Actions

Authored by deadalnix on Jul 13 2017, 21:13.

Details

Reviewers
freetrader
dagurval
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc40c59a79406: Update URL for website and source code
rABCc40c59a79406: Update URL for website and source code
Test Plan

Manual testing (open qt app, view about dialog)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dagurval created this revision.Jul 13 2017, 21:13
Owners added a reviewer: Restricted Owners Package.Jul 13 2017, 21:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 13 2017, 21:13
Harbormaster completed remote builds in B498: Diff 800.Jul 13 2017, 21:13
deadalnix requested changes to this revision.Jul 13 2017, 22:09
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/init.cpp
1 ↗(On Diff #800)

Please fix.

This revision now requires changes to proceed.Jul 13 2017, 22:09
deadalnix added a comment.Jul 13 2017, 22:31

The stupid part is that I have a diff for this, but forgot to diff out :)

dagurval added inline comments.Jul 13 2017, 22:38
src/init.cpp
1 ↗(On Diff #800)

You want me to reformat the whole file together with this tiny change?

deadalnix added a comment.Jul 13 2017, 23:29

The file is already formatted.

dagurval updated this revision to Diff 806.Jul 14 2017, 03:40
dagurval edited edge metadata.

ran 'arc lint'

freetrader accepted this revision.Jul 14 2017, 08:19
deadalnix added a comment.Jul 14 2017, 10:04

What version of clang format do you have on you computer ? This was already formatted so it is kind of weird that get that many changes.

deadalnix requested changes to this revision.Jul 14 2017, 10:04
This revision now requires changes to proceed.Jul 14 2017, 10:04
dagurval added a comment.EditedJul 14 2017, 18:21
In D322#5435, @deadalnix wrote:

What version of clang format do you have on you computer ? This was already formatted so it is kind of weird that get that many changes.

$ clang-format --version
clang-format version 5.0.0 (tags/google/stable/2017-06-22)

I can install 3.8 instead if that helps

freetrader added a comment.EditedJul 14 2017, 18:48

@dagurval :

I noticed on BU that clang-format from 5.x formats differently .

Use clang-format-3.8 - it works compatibly with BU and ABC .

dagurval updated this revision to Diff 829.Jul 14 2017, 21:06
dagurval edited edge metadata.

ran 'arc lint' with clang-format 3.8

Harbormaster completed remote builds in B517: Diff 829.Jul 14 2017, 21:06
freetrader accepted this revision.Jul 14 2017, 21:34

Manually tested, looks ok to me.

deadalnix accepted this revision.Jul 14 2017, 23:34
This revision is now accepted and ready to land.Jul 14 2017, 23:34
deadalnix commandeered this revision.Jul 15 2017, 00:37
deadalnix edited reviewers, added: dagurval; removed: deadalnix.
Closed by commit rABCc40c59a79406: Update URL for website and source code (authored by dagurval, committed by deadalnix). · Explain WhyJul 15 2017, 00:40
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
7 lines

Diff 831

View Options

src/init.cpp

Loading...