Avoid spurious boost output in scheduler_tests
ClosedPublic
Actions

Authored by Fabien on Jun 6 2019, 11:14.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGaa668d1eb240: Avoid spurious boost output in scheduler_tests
rABCaa668d1eb240: Avoid spurious boost output in scheduler_tests

Summary

Boost test macros try to output some message, which leads to a messy
debug output when called in intricated threads.
Use assert in these cases solves the issue.

Backport of Core PR14069
https://github.com/bitcoin/bitcoin/pull/14069/files

Test Plan

./src/test/test_bitcoin -t scheduler_tests

Without the patch it will sometime output partial boost debug info.
With the patch the output will remain clean.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6181
Build 10410: Bitcoin ABC Buildbot (legacy)
Build 10409: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 6 2019, 11:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2019, 11:14

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6181: Diff 9188.Jun 6 2019, 11:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Added a note in the summary that this is a backport.

Also consider backporting this as well: https://github.com/bitcoin/bitcoin/pull/14088/files

This revision is now accepted and ready to land.Jun 6 2019, 18:21

@jasonbcox Thanks for the summary, I missed the backport.
I will backport the follow-up.

Closed by commit rABCaa668d1eb240: Avoid spurious boost output in scheduler_tests (authored by Fabien). · Explain WhyJun 6 2019, 18:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCaa668d1eb240: Avoid spurious boost output in scheduler_tests.

I guess one frustrating thing with assert is that it doesn't throw an exception (just kills program without any information), if it happens that these fail for some reason.

Fabien mentioned this in D3277: Don't assert(...) with side effects.Jun 10 2019, 13:09

Fabien mentioned this in rABC3a0a0966a1d1: Don't assert(...) with side effects.Jun 10 2019, 21:19

Fabien added a commit: rSTAGINGaa668d1eb240: Avoid spurious boost output in scheduler_tests.Sep 19 2019, 00:05

Fabien mentioned this in rSTAGING3a0a0966a1d1: Don't assert(...) with side effects.Sep 19 2019, 00:10