Page MenuHomePhabricator
Differential D3246

Use a struct for output eligibility
ClosedPublic
Actions

Authored by deadalnix on Jun 6 2019, 23:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGcd606f147cba: Use a struct for output eligibility
rABCcd606f147cba: Use a struct for output eligibility
Summary

Instead of specifying 3 parameters, use a struct for those parameters
in order to reduce the number of arguments to SelectCoinsMinConf.

This is a partial backport of Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/7d77eb1a5b980a7d56acbf0b3861434c5e195c54

Depends on D3245

Test Plan
mae check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
eligibilitystruct
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6200
Build 10447: Bitcoin ABC Buildbot (legacy)
Build 10446: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 6 2019, 23:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2019, 23:44
teamcity added a comment.Jun 6 2019, 23:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B6200: Diff 9227!Jun 7 2019, 00:00
teamcity added a comment.Jun 7 2019, 00:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Jun 7 2019, 09:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien accepted this revision.Jun 7 2019, 09:56
This revision is now accepted and ready to land.Jun 7 2019, 09:56
teamcity added a comment.Jun 7 2019, 10:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6200: Diff 9227.Jun 7 2019, 10:01
deadalnix added a child revision: D3289: Move current coin selection algorithm to coinselection.{cpp,h}.Jun 11 2019, 16:24
Closed by commit rABCcd606f147cba: Use a struct for output eligibility (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJun 12 2019, 15:18
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCcd606f147cba: Use a struct for output eligibility.
deadalnix added a commit: rSTAGINGcd606f147cba: Use a struct for output eligibility.Sep 19 2019, 00:14

Revision Contents
Changeset List

PathSize
src/
bench/
5 lines
wallet/
test/
155 lines
22 lines
64 lines

Diff 9227

View Options

src/bench/coin_selection.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...