Page MenuHomePhabricator

add new encoding checker for Schnorr sigs
ClosedPublic

Authored by markblundeberg on Jun 8 2019, 21:46.

Details

Summary

Part of effort to add new CHECKMULTISIG mode.

Depends on D3417

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
schnorrenconly
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6488
Build 11023: Bitcoin ABC Buildbot (legacy)
Build 11022: arc lint + arc unit

Event Timeline

src/script/script_error.cpp
88 ↗(On Diff #9262)

And the comment something like: "Signature must be validly encoded Schnorr, or null, in this operation".

It's not really checking for ECDSA, but that it's a validly encoded Schnorr.

src/script/script_error.h
66 ↗(On Diff #9262)

I think it would be better to call it something like "SCRIPT_ERR_SIG_BADSCHNORR".

markblundeberg added inline comments.
src/script/script_error.cpp
88 ↗(On Diff #9262)

Good points

markblundeberg marked 2 inline comments as done.

update per comments

deadalnix requested changes to this revision.Jun 12 2019, 13:06
deadalnix added inline comments.
src/script/sigencoding.cpp
183 ↗(On Diff #9274)

The fact you duplicated logic is a tell the design isn't quite right.

This revision now requires changes to proceed.Jun 12 2019, 13:06
markblundeberg edited the summary of this revision. (Show Details)

refactored out schnorr detector into D3417

src/script/sigencoding.h
56

authentify -> authenticate

This revision is now accepted and ready to land.Jun 28 2019, 13:58
src/script/sigencoding.h
56

I'm copying the previous comments here, will open another diff to fix them up. :-)