Page MenuHomePhabricator

move CheckMinimalPush to script.h
AbandonedPublic

Authored by markblundeberg on Jun 9 2019, 02:27.

Details

Reviewers
jasonbcox
Mengerian
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T667: add rule for **minimal** push only in scriptSig
Summary

Part of effort to get a scriptsig push restriction consensuse rule that is actually effective in reducing third party malleability, see T667.

changes valtype to vector<uint8_t>, as appropriate for this file.
static -> inline to avoid unused warnings.

Test Plan

make check

Diff Detail

Event Timeline

markblundeberg created this revision.Jun 9 2019, 02:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2019, 02:27
jasonbcox requested changes to this revision.Jun 10 2019, 16:50

While mildly useful, I don't think we should be making changes like this until backports are up-to-date.

This revision now requires changes to proceed.Jun 10 2019, 16:50
markblundeberg edited the summary of this revision. (Show Details)Jun 10 2019, 17:48
markblundeberg requested review of this revision.Jun 10 2019, 17:50

While mildly useful, I don't think we should be making changes like this until backports are up-to-date.

This is irrelevant unless substantiated.

markblundeberg planned changes to this revision.Jun 13 2019, 22:31
markblundeberg abandoned this revision.Jun 19 2019, 15:52