Page MenuHomePhabricator
Differential D3269

move CheckMinimalPush to script.h
AbandonedPublic
Actions

Authored by markblundeberg on Jun 9 2019, 02:27.

Details

Reviewers
jasonbcox
Mengerian
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T667: add rule for **minimal** push only in scriptSig
Summary

Part of effort to get a scriptsig push restriction consensuse rule that is actually effective in reducing third party malleability, see T667.

changes valtype to vector<uint8_t>, as appropriate for this file.
static -> inline to avoid unused warnings.

Test Plan

make check

Diff Detail

Event Timeline

markblundeberg created this revision.Jun 9 2019, 02:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2019, 02:27
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 9 2019, 02:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a child revision: D3270: add CScript::IsMinimalPushOnly.Jun 9 2019, 02:28
markblundeberg added a task: T667: add rule for **minimal** push only in scriptSig.Jun 9 2019, 02:30
teamcity added a comment.Jun 9 2019, 02:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6230: Diff 9268.Jun 9 2019, 02:38
jasonbcox requested changes to this revision.Jun 10 2019, 16:50

While mildly useful, I don't think we should be making changes like this until backports are up-to-date.

This revision now requires changes to proceed.Jun 10 2019, 16:50
markblundeberg edited the summary of this revision. (Show Details)Jun 10 2019, 17:48
markblundeberg requested review of this revision.Jun 10 2019, 17:50
deadalnix added a comment.Jun 11 2019, 23:46
In D3269#77348, @jasonbcox wrote:

While mildly useful, I don't think we should be making changes like this until backports are up-to-date.

This is irrelevant unless substantiated.

markblundeberg planned changes to this revision.Jun 13 2019, 22:31
markblundeberg abandoned this revision.Jun 19 2019, 15:52

Revision Contents
Changeset List

PathSize
src/
script/
29 lines
30 lines

Diff 9268

View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script.h

Loading...