Page MenuHomePhabricator
Differential D3276

Avoid unintentional unsigned integer wraparounds in tests
ClosedPublic
Actions

Authored by Fabien on Jun 10 2019, 12:16.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING87ff2706705c: Avoid unintentional unsigned integer wraparounds in tests
rABC87ff2706705c: Avoid unintentional unsigned integer wraparounds in tests
Summary

Backport of core PR12516
https://github.com/bitcoin/bitcoin/pull/12516/files

Depends on D3275

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12516
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6244
Build 10535: Bitcoin ABC Buildbot (legacy)
Build 10534: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 10 2019, 12:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2019, 12:16
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 10 2019, 12:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien planned changes to this revision.Jun 10 2019, 12:20
teamcity added a comment.Jun 10 2019, 12:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6244: Diff 9284.Jun 10 2019, 12:22
Fabien updated this revision to Diff 9285.Jun 10 2019, 12:27

Squash the fix

teamcity added a comment.Jun 10 2019, 12:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien planned changes to this revision.Jun 10 2019, 12:28
Fabien edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B6245: Diff 9285.Jun 10 2019, 12:33
teamcity added a comment.Jun 10 2019, 12:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien edited the summary of this revision. (Show Details)Jun 10 2019, 12:34
Fabien updated this revision to Diff 9287.Jun 10 2019, 12:36

Reverted squashing the fix as it belongs to D3275

teamcity added a comment.Jun 10 2019, 12:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 10 2019, 12:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6247: Diff 9287.Jun 10 2019, 12:47
jasonbcox accepted this revision.Jun 10 2019, 16:47
This revision is now accepted and ready to land.Jun 10 2019, 16:47
Closed by commit rABC87ff2706705c: Avoid unintentional unsigned integer wraparounds in tests (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJun 10 2019, 21:22
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC87ff2706705c: Avoid unintentional unsigned integer wraparounds in tests.
Fabien added a commit: rSTAGING87ff2706705c: Avoid unintentional unsigned integer wraparounds in tests.Sep 19 2019, 00:10

Revision Contents
Changeset List

PathSize
src/
test/
6 lines
4 lines
wallet/
test/
4 lines

Diff 9284

View Options

src/test/prevector_tests.cpp

Loading...
View Options

src/test/scheduler_tests.cpp

Loading...
View Options

src/wallet/test/accounting_tests.cpp

Loading...