Page MenuHomePhabricator

[txindex] transaction Hash -> TxId
ClosedPublic

Authored by markblundeberg on Jun 13 2019, 23:34.

Details

Summary

this updates for current ABC convention, using GetId() instead of
GetHash(), and using the TxId type.

Migration-related types have been left as uint256 since that was how the old
txindex code worked.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txindex_txid
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6326
Build 10699: Bitcoin ABC Buildbot (legacy)
Build 10698: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Jun 14 2019, 00:24
jasonbcox added inline comments.
src/index/txindex.cpp
58

hash -> tx ID

src/index/txindex.h
44

Don't let this fall out of date.

This revision now requires changes to proceed.Jun 14 2019, 00:24
This revision is now accepted and ready to land.Jun 14 2019, 16:18

rebase for conflict (txindex_tests' GetHash -> GetId changes were done in D3315 too)