Page MenuHomePhabricator
Differential D3393

wallet: Add output grouping
ClosedPublic
Actions

Authored by deadalnix on Jun 22 2019, 21:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING7bc2342c29d0: wallet: Add output grouping
rABC7bc2342c29d0: wallet: Add output grouping
Summary

This is a patial backport of Core PR12257 : https://github.com/bitcoin/bitcoin/pull/12257/commits/87ebce25d66952f5ce565bb5130dcf5e24049872

Depends on D3390 and D3391

Also includes the following bug fix:

  • [wallet] correctly limit output group size

Extracted from Core PR13805 : https://github.com/bitcoin/bitcoin/pull/13805/commits/57ec1c97b2d0c0ba6056a43fa4177efc39567ae2

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
addoutputgrouping
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6474
Build 10995: Bitcoin ABC Buildbot (legacy)
Build 10994: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 22 2019, 21:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2019, 21:31
teamcity added a comment.Jun 22 2019, 21:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6449: Diff 9596.Jun 22 2019, 21:38
teamcity added a comment.Jun 22 2019, 21:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D3394: wallet: Switch to using output groups instead of coins in coin selection.Jun 22 2019, 21:47
Fabien requested changes to this revision.Jun 24 2019, 11:21
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
4619 ↗(On Diff #9596)

This is buggy and fixed in PR13805.
You should consider backporting it (along with this diff or in a follow-up, up to you).

4634 ↗(On Diff #9596)

Braces

This revision now requires changes to proceed.Jun 24 2019, 11:21
deadalnix edited the summary of this revision. (Show Details)Jun 25 2019, 14:18
deadalnix updated this revision to Diff 9645.Jun 25 2019, 14:22

Backport bugfix from PR13805

teamcity added a comment.Jun 25 2019, 14:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6474: Diff 9645.Jun 25 2019, 14:29
teamcity added a comment.Jun 25 2019, 14:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Jun 25 2019, 14:37

Talked offline: the test part of PR13805 is going to be integrated to the diff that backport the test.

This revision is now accepted and ready to land.Jun 25 2019, 14:37
Closed by commit rABC7bc2342c29d0: wallet: Add output grouping (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by deadalnix). · Explain WhyJun 25 2019, 14:51
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC7bc2342c29d0: wallet: Add output grouping.
deadalnix added a commit: rSTAGING7bc2342c29d0: wallet: Add output grouping.Sep 19 2019, 00:31

Revision Contents
Changeset List

PathSize
src/
wallet/
28 lines
45 lines
2 lines
41 lines

Diff 9645

View Options

src/wallet/coinselection.h

Loading...
View Options

src/wallet/coinselection.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...