Page MenuHomePhabricator

wallet: Add output grouping
ClosedPublic

Authored by deadalnix on Jun 22 2019, 21:31.

Details

Summary

This is a patial backport of Core PR12257 : https://github.com/bitcoin/bitcoin/pull/12257/commits/87ebce25d66952f5ce565bb5130dcf5e24049872

Depends on D3390 and D3391

Also includes the following bug fix:

  • [wallet] correctly limit output group size

Extracted from Core PR13805 : https://github.com/bitcoin/bitcoin/pull/13805/commits/57ec1c97b2d0c0ba6056a43fa4177efc39567ae2

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
addoutputgrouping
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6474
Build 10995: Bitcoin ABC Buildbot (legacy)
Build 10994: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Jun 24 2019, 11:21
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
4619 ↗(On Diff #9596)

This is buggy and fixed in PR13805.
You should consider backporting it (along with this diff or in a follow-up, up to you).

4634 ↗(On Diff #9596)

Braces

This revision now requires changes to proceed.Jun 24 2019, 11:21

Backport bugfix from PR13805

Talked offline: the test part of PR13805 is going to be integrated to the diff that backport the test.

This revision is now accepted and ready to land.Jun 25 2019, 14:37
This revision was automatically updated to reflect the committed changes.