Page MenuHomePhabricator

Merge #10655: Properly document target_confirmations in listsinceblock
ClosedPublic

Authored by markblundeberg on Jun 30 2019, 19:41.

Details

Summary

PR10655 backport https://github.com/bitcoin/bitcoin/pull/10655/files
9f8a46f Properly document target_confirmations in listsinceblock (Ryan Havar)

Pull request description:

There seems to be some misunderstandings about this, but it's a heavily used function so I'd like to make sure the docs are clear about how it works.

For a later issue:
* Change the default of target_confirmations to 6  (1 is a pretty silly default)
* Change the name of target_confirmations (it's really a horrible name)
Test Plan

make check
read

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 30 2019, 20:48