Paths

Table of Contentst

Merge #9577: Fix docstrings in qa tests
ClosedPublic
Actions

Authored by markblundeberg on Jul 1 2019, 16:00.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGf875fe4e55dc: Merge #9577: Fix docstrings in qa tests
rABCf875fe4e55dc: Merge #9577: Fix docstrings in qa tests

Summary

PR9577 backport https://github.com/bitcoin/bitcoin/pull/9577/files
3f95a80 Fix docstrings in qa tests (John Newbery)

Not sure why this wasn't backported sooner. I got about 80 conflicts,
dozens of failed rename detections, and there were many many cases where
the docstring had already been backported. Many of the tests are also
just gone now.

Test Plan

test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6593
Build 11233: Bitcoin ABC Buildbot (legacy)
Build 11232: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 1 2019, 16:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2019, 16:00

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg mentioned this in D3494: Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework.Jul 1 2019, 16:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6593: Diff 9859.Jul 1 2019, 16:12

markblundeberg added a child revision: D3494: Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework.Jul 1 2019, 16:45

Fabien accepted this revision.Jul 1 2019, 18:16

This revision is now accepted and ready to land.Jul 1 2019, 18:16

Closed by commit rABCf875fe4e55dc: Merge #9577: Fix docstrings in qa tests (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 1 2019, 20:20

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCf875fe4e55dc: Merge #9577: Fix docstrings in qa tests.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGf875fe4e55dc: Merge #9577: Fix docstrings in qa tests.Sep 19 2019, 00:49

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_bip68_sequence.py

5 lines

feature_block.py

17 lines

feature_maxuploadtarget.py

7 lines

22 lines

4 lines

12 lines

9 lines

5 lines

5 lines

3 lines

8 lines

6 lines

mempool_spend_coinbase.py

19 lines

mining_getblocktemplate_longpoll.py

1 line

mining_prioritisetransaction.py

5 lines

10 lines

6 lines

18 lines

8 lines

3 lines

5 lines

2 lines

p2p_unrequested_blocks.py

62 lines

rpc_bind.py

3 lines

rpc_decodescript.py

3 lines

rpc_getchaintips.py

9 lines

rpc_invalidateblock.py

5 lines

rpc_listtransactions.py

3 lines

rpc_named_arguments.py

1 line

rpc_preciousblock.py

5 lines

rpc_rawtransaction.py

17 lines

rpc_signmessage.py

1 line

rpc_txoutproof.py

5 lines

rpc_users.py

5 lines

wallet_import_rescan.py

5 lines

wallet_importmulti.py

2 lines

wallet_importprunedfunds.py

1 line

wallet_keypool.py

3 lines

wallet_listreceivedby.py

2 lines

wallet_listsinceblock.py

2 lines

Diff 9859

View Options

test/functional/feature_bip68_sequence.py

View Options

test/functional/feature_block.py

View Options

test/functional/feature_maxuploadtarget.py

View Options

test/functional/feature_nulldummy.py

View Options

test/functional/feature_proxy.py

View Options

test/functional/feature_pruning.py

View Options

test/functional/feature_reindex.py

View Options

test/functional/interface_http.py

View Options

test/functional/interface_rest.py

View Options

test/functional/mempool_limit.py

View Options

test/functional/mempool_reorg.py

View Options

test/functional/mempool_resurrect.py

View Options

test/functional/mempool_spend_coinbase.py

View Options

test/functional/mining_getblocktemplate_longpoll.py

View Options

test/functional/mining_prioritisetransaction.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/p2p_feefilter.py

View Options

test/functional/p2p_invalid_block.py

View Options

test/functional/p2p_invalid_tx.py

View Options

test/functional/p2p_leak.py

View Options

test/functional/p2p_mempool.py

View Options

test/functional/p2p_timeouts.py

View Options

test/functional/p2p_unrequested_blocks.py

View Options

test/functional/rpc_bind.py

View Options

test/functional/rpc_decodescript.py

View Options

test/functional/rpc_getchaintips.py

View Options

test/functional/rpc_invalidateblock.py

View Options

test/functional/rpc_listtransactions.py

View Options

test/functional/rpc_named_arguments.py

View Options

test/functional/rpc_preciousblock.py

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/rpc_signmessage.py

View Options

test/functional/rpc_txoutproof.py

View Options

test/functional/rpc_users.py

View Options

test/functional/wallet_import_rescan.py

View Options

test/functional/wallet_importmulti.py

View Options

test/functional/wallet_importprunedfunds.py

View Options

test/functional/wallet_keypool.py

View Options

test/functional/wallet_listreceivedby.py

View Options

test/functional/wallet_listsinceblock.py

Merge #9577: Fix docstrings in qa testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9859

test/functional/feature_bip68_sequence.py

test/functional/feature_block.py

test/functional/feature_maxuploadtarget.py

test/functional/feature_nulldummy.py

test/functional/feature_proxy.py

test/functional/feature_pruning.py

test/functional/feature_reindex.py

test/functional/interface_http.py

test/functional/interface_rest.py

test/functional/mempool_limit.py

test/functional/mempool_reorg.py

test/functional/mempool_resurrect.py

test/functional/mempool_spend_coinbase.py

test/functional/mining_getblocktemplate_longpoll.py

test/functional/mining_prioritisetransaction.py

test/functional/p2p_compactblocks.py

test/functional/p2p_feefilter.py

test/functional/p2p_invalid_block.py

test/functional/p2p_invalid_tx.py

test/functional/p2p_leak.py

test/functional/p2p_mempool.py

test/functional/p2p_timeouts.py

test/functional/p2p_unrequested_blocks.py

test/functional/rpc_bind.py

test/functional/rpc_decodescript.py

test/functional/rpc_getchaintips.py

test/functional/rpc_invalidateblock.py

test/functional/rpc_listtransactions.py

test/functional/rpc_named_arguments.py

test/functional/rpc_preciousblock.py

test/functional/rpc_rawtransaction.py

test/functional/rpc_signmessage.py

test/functional/rpc_txoutproof.py

test/functional/rpc_users.py

test/functional/wallet_import_rescan.py

test/functional/wallet_importmulti.py

test/functional/wallet_importprunedfunds.py

test/functional/wallet_keypool.py

test/functional/wallet_listreceivedby.py

test/functional/wallet_listsinceblock.py

Merge #9577: Fix docstrings in qa tests
ClosedPublic
Actions

Revision Contents
Changeset List