Paths

Table of Contentst

Differential D3503

Fix 'mempool min fee not met' debug output
ClosedPublic
Actions

Authored by Fabien on Jul 1 2019, 17:48.

Tags

None

Subscribers

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING7ea9dd7d9825: Fix 'mempool min fee not met' debug output
rABC7ea9dd7d9825: Fix 'mempool min fee not met' debug output

Summary

Output the value that is tested, rather than the unmodified fee value.

Backport of core PR12356 (main), PR12512 and PR12455 (fixes)
https://github.com/bitcoin/bitcoin/pull/12356/files
https://github.com/bitcoin/bitcoin/pull/12512/files
https://github.com/bitcoin/bitcoin/pull/12455/files

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 1 2019, 17:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2019, 17:48

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6598: Diff 9867.Jul 1 2019, 17:55

jasonbcox accepted this revision.Jul 1 2019, 20:45

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

test/functional/abc-mempool-accept-txn.py
46 ↗	(On Diff #9867)	Since the python test suite checks asserts using an `x in err_msg` check, this is fine. Just pointing out that this message is missing the `code(...)` part like the other messages.

This revision is now accepted and ready to land.Jul 1 2019, 20:45

Fabien added inline comments.Jul 1 2019, 20:54

test/functional/abc-mempool-accept-txn.py
46 ↗	(On Diff #9867)	This is done on purpose. The whole message gives you the number of sigops in the failure reason (`bad-txns-too-many-sigops, #sigops (code 42)`), doing so avoid computing the whole exact reason string and is less likely to break at each script update.

Closed by commit rABC7ea9dd7d9825: Fix 'mempool min fee not met' debug output (authored by Ben Woosley <ben.woosley@gmail.com>, committed by Fabien). · Explain WhyJul 2 2019, 06:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7ea9dd7d9825: Fix 'mempool min fee not met' debug output.

Fabien added a commit: rSTAGING7ea9dd7d9825: Fix 'mempool min fee not met' debug output.Sep 19 2019, 00:51

Revision Contents
Changeset List

Path

Size

src/

rpc/

6 lines

4 lines

rawtransaction.cpp

6 lines

6 lines

wallet/

4 lines

2 lines

test/

functional/

abc-mempool-accept-txn.py

4 lines

abc-mempool-coherence-on-activations.py

4 lines

abc-replay-protection.py

4 lines

4 lines

abc-segwit-recovery.py

6 lines

feature_bip68_sequence.py

2 lines

feature_nulldummy.py

2 lines

mempool_limit.py

17 lines

mining_prioritisetransaction.py

2 lines

Diff 9903

src/rpc/blockchain.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/validation.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/wallet.cpp

Loading...

test/functional/abc-mempool-accept-txn.py

Loading...

test/functional/abc-mempool-coherence-on-activations.py

Loading...

test/functional/abc-replay-protection.py

Loading...

test/functional/abc-schnorr.py

Loading...

test/functional/abc-segwit-recovery.py

Loading...

test/functional/feature_bip68_sequence.py

Loading...

test/functional/feature_nulldummy.py

Loading...

test/functional/mempool_limit.py

Loading...

test/functional/mining_prioritisetransaction.py

Loading...