Page MenuHomePhabricator

Prettify README title
ClosedPublic

Authored by Mengerian on Jul 2 2019, 04:24.

Details

Summary

This will make the README title render with a nice-looking graphic in Github.

Test Plan

Have a look at: https://github.com/Mengerian/bitcoin-abc/tree/readme-logo
Scroll down to see the README
Hover over logo with mouse, see that "Bitcoin ABC" tooltip appears
Click on logo, it should take you to the bitcoinabc.org website
Check that alt text with broken image link works at:
https://github.com/Mengerian/bitcoin-abc/blob/readme-logo-2/README.md

Diff Detail

Repository
rABC Bitcoin ABC
Branch
readme-logo
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6624
Build 11295: Bitcoin ABC Buildbot (legacy)
Build 11294: arc lint + arc unit

Event Timeline

markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
README.md
1 ↗(On Diff #9900)

Something should be put in place of "alt text" ... if I understand right, the appropriate text would be "Bitcoin ABC Logo".

https://www.w3schools.com/tags/att_img_alt.asp

This revision now requires changes to proceed.Jul 2 2019, 05:43
Mengerian edited the test plan for this revision. (Show Details)

Update test plan for alt text

I still think "Bitcoin ABC Logo" is more appropriate (alt text is a substitute for the image), but OK :-)

Dunno why it says "These changes have failed to build."

This revision is now accepted and ready to land.Jul 2 2019, 15:18

Change alt text to "Bitcoin ABC Logo"

@markblundeberg No worry regarding the test fail, it's fixed by D3476
@Mengerian You can rebase if you want to get rid of the failure (I think it would prevent you from landing otherwise)

This revision was automatically updated to reflect the committed changes.