Details

Reviewers

deadalnix
jasonbcox
markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGING8df68739c056: Prettify README title
rABC8df68739c056: Prettify README title

Summary

This will make the README title render with a nice-looking graphic in Github.

Test Plan

Have a look at: https://github.com/Mengerian/bitcoin-abc/tree/readme-logo
Scroll down to see the README
Hover over logo with mouse, see that "Bitcoin ABC" tooltip appears
Click on logo, it should take you to the bitcoinabc.org website
Check that alt text with broken image link works at:
https://github.com/Mengerian/bitcoin-abc/blob/readme-logo-2/README.md

Diff Detail

Repository

rABC Bitcoin ABC

Branch

readme-logo

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6624
Build 11295: Bitcoin ABC Buildbot (legacy)
Build 11294: arc lint + arc unit

Event Timeline

Mengerian created this revision.Jul 2 2019, 04:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2019, 04:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6615: Diff 9900.Jul 2 2019, 04:35

Mengerian added a reviewer: jasonbcox.Jul 2 2019, 05:21

markblundeberg requested changes to this revision.Jul 2 2019, 05:43

markblundeberg added a subscriber: markblundeberg.

markblundeberg added inline comments.

README.md
1 ↗	(On Diff #9900)	Something should be put in place of "alt text" ... if I understand right, the appropriate text would be "Bitcoin ABC Logo". https://www.w3schools.com/tags/att_img_alt.asp

This revision now requires changes to proceed.Jul 2 2019, 05:43

Fix alt text

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Update test plan for alt text

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B6624: Diff 9910!Jul 2 2019, 15:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster completed remote builds in B6623: Diff 9909.Jul 2 2019, 15:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

I still think "Bitcoin ABC Logo" is more appropriate (alt text is a substitute for the image), but OK :-)

Dunno why it says "These changes have failed to build."

This revision is now accepted and ready to land.Jul 2 2019, 15:18

Change alt text to "Bitcoin ABC Logo"

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6625: Diff 9911.Jul 2 2019, 15:53

@markblundeberg No worry regarding the test fail, it's fixed by D3476
@Mengerian You can rebase if you want to get rid of the failure (I think it would prevent you from landing otherwise)