[test] Round target fee to 8 decimals in assert_fee_amount
ClosedPublic
Actions

Authored by Fabien on Jul 2 2019, 12:21.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGc662dd52fc13: [test] Round target fee to 8 decimals in assert_fee_amount
rABCc662dd52fc13: [test] Round target fee to 8 decimals in assert_fee_amount

Summary

The output would produce arbitrary number of decimal points, sometimes
resulting in 9 decimals:
AssertionError: Fee of 0.00000415 BTC too low! (Should be 0.000006175
BTC)
The above looks like the expected fee is 6175 sats when in reality it's
618.

Backport of core PR12486
https://github.com/bitcoin/bitcoin/pull/12486/files

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12486

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6619
Build 11285: Bitcoin ABC Buildbot (legacy)
Build 11284: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 2 2019, 12:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2019, 12:21

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6619: Diff 9905.Jul 2 2019, 12:28

jasonbcox accepted this revision.Jul 3 2019, 00:26

This revision is now accepted and ready to land.Jul 3 2019, 00:26

Closed by commit rABCc662dd52fc13: [test] Round target fee to 8 decimals in assert_fee_amount (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by Fabien). · Explain WhyJul 3 2019, 15:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc662dd52fc13: [test] Round target fee to 8 decimals in assert_fee_amount.

Fabien added a commit: rSTAGINGc662dd52fc13: [test] Round target fee to 8 decimals in assert_fee_amount.Sep 19 2019, 00:54

PiRK mentioned this in D10267: use the correct rounding in assert_fee_amount.Oct 6 2021, 12:36

PiRK mentioned this in rABC9476c912c0b7: use the correct rounding in assert_fee_amount.Oct 6 2021, 16:34

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

util.py

2 lines

Diff 9905

View Options

test/functional/test_framework/util.py

[test] Round target fee to 8 decimals in assert_fee_amountClosedPublicActions