Page MenuHomePhabricator

Only generate cashaddr URI from the GUI
ClosedPublic

Authored by deadalnix on Jul 3 2019, 01:14.

Details

Summary

This is a first step toward deprecating the legacy address format. The Qt interface is not widely used and we can simplify quite a bit of code doing so.

Test Plan

Updated the test cases for URI generation.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jul 3 2019, 01:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2019, 01:14
markblundeberg requested changes to this revision.Jul 5 2019, 16:14

How can I test this -- just make check? Also, if rebased on the new master it shouldn't have this unrelated test error.

This revision now requires changes to proceed.Jul 5 2019, 16:14
markblundeberg accepted this revision.Jul 6 2019, 16:27
This revision is now accepted and ready to land.Jul 6 2019, 16:27
This revision was automatically updated to reflect the committed changes.