Take CChainParams explicitely in PaymentServer
ClosedPublic
Actions

Authored by deadalnix on Jul 4 2019, 15:58.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe328c02961d8: Take CChainParams explicitely in PaymentServer
rABCe328c02961d8: Take CChainParams explicitely in PaymentServer

Summary

Take CChainParams instead of a prefix. This loses the legacy address support, but allow for further simplification.

Depends on D3539

Test Plan

Build and run btcoin-qt
Use the open URI feature and ensure it still works.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 4 2019, 15:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2019, 15:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6665: Diff 9980.Jul 4 2019, 16:05

deadalnix added a child revision: D3549: Use CashAddr everywhere in the Qt interface.Jul 4 2019, 17:22

markblundeberg accepted this revision.Jul 5 2019, 16:22

This revision is now accepted and ready to land.Jul 5 2019, 16:22

Closed by commit rABCe328c02961d8: Take CChainParams explicitely in PaymentServer (authored by deadalnix). · Explain WhyJul 6 2019, 14:07

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCe328c02961d8: Take CChainParams explicitely in PaymentServer.

deadalnix added a commit: rSTAGINGe328c02961d8: Take CChainParams explicitely in PaymentServer.Sep 19 2019, 00:59

Revision Contents
Changeset List

Path

Size

src/

qt/

paymentserver.h

2 lines

paymentserver.cpp

15 lines

Diff 10031

View Options

src/qt/paymentserver.h