Use CashAddr everywhere in the Qt interface
ClosedPublic
Actions

Authored by deadalnix on Jul 4 2019, 17:22.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7012821336a0: Use CashAddr everywhere in the Qt interface
rABC7012821336a0: Use CashAddr everywhere in the Qt interface

Summary

As per title.

Depends on D3548

Test Plan

Run bitcoin-qt using usecashaddr=0 . It all works and cashaddr is used anyways.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 4 2019, 17:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2019, 17:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D3550: Remove EncodeDestination's overload relying on global state.Jul 4 2019, 17:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6667: Diff 9983.Jul 4 2019, 17:29

deadalnix added a child revision: D3551: Default to cashaddr in most of the Qt API.Jul 4 2019, 19:13

markblundeberg accepted this revision.Jul 5 2019, 16:21

This revision is now accepted and ready to land.Jul 5 2019, 16:21

Closed by commit rABC7012821336a0: Use CashAddr everywhere in the Qt interface (authored by deadalnix). · Explain WhyJul 6 2019, 14:10

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC7012821336a0: Use CashAddr everywhere in the Qt interface.

deadalnix added a commit: rSTAGING7012821336a0: Use CashAddr everywhere in the Qt interface.Sep 19 2019, 00:59

jasonbcox mentioned this in D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.Jun 24 2020, 22:27

Revision Contents
Changeset List

Path

Size

src/

qt/

addresstablemodel.cpp

7 lines

coincontroldialog.cpp

9 lines

paymentserver.cpp

4 lines

test/

wallettests.cpp

3 lines

transactiondesc.cpp

9 lines

transactionrecord.cpp

8 lines

walletmodel.cpp

7 lines

Diff 10032

View Options

src/qt/addresstablemodel.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

Use CashAddr everywhere in the Qt interfaceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10032

src/qt/addresstablemodel.cpp

src/qt/coincontroldialog.cpp

src/qt/paymentserver.cpp

src/qt/test/wallettests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/qt/walletmodel.cpp

Use CashAddr everywhere in the Qt interface
ClosedPublic
Actions

Revision Contents
Changeset List