Differential D3536

Only generate cashaddr URI from the GUI
ClosedPublic
Actions

Authored by deadalnix on Jul 3 2019, 01:14.

Details

Reviewers

markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGbb02e6dd4724: Only generate cashaddr URI from the GUI
rABCbb02e6dd4724: Only generate cashaddr URI from the GUI

Summary

This is a first step toward deprecating the legacy address format. The Qt interface is not widely used and we can simplify quite a bit of code doing so.

Test Plan

Updated the test cases for URI generation.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

formatBitcoinURI

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6697
Build 11441: Bitcoin ABC Buildbot (legacy)
Build 11440: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 3 2019, 01:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2019, 01:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6648: Diff 9946!Jul 3 2019, 01:18

Concept ACK!

deadalnix added a child revision: D3550: Remove EncodeDestination's overload relying on global state.Jul 4 2019, 17:25

deadalnix added a child revision: D3551: Default to cashaddr in most of the Qt API.Jul 4 2019, 19:13

How can I test this -- just make check? Also, if rebased on the new master it shouldn't have this unrelated test error.

This revision now requires changes to proceed.Jul 5 2019, 16:14

Rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6697: Diff 10035.Jul 6 2019, 15:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg accepted this revision.Jul 6 2019, 16:27

This revision is now accepted and ready to land.Jul 6 2019, 16:27

Closed by commit rABCbb02e6dd4724: Only generate cashaddr URI from the GUI (authored by deadalnix). · Explain WhyJul 6 2019, 16:46

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCbb02e6dd4724: Only generate cashaddr URI from the GUI.

deadalnix added a commit: rSTAGINGbb02e6dd4724: Only generate cashaddr URI from the GUI.Sep 19 2019, 00:59

Revision Contents
Changeset List

Path

Size

src/

base58.h

3 lines

base58.cpp

6 lines

qt/

2 lines

7 lines

21 lines

4 lines

receivecoinsdialog.cpp

12 lines

receiverequestdialog.h

5 lines

receiverequestdialog.cpp

16 lines

test/

17 lines

46 lines

8 lines

4 lines

7 lines

4 lines

5 lines

Diff 10035

View Options

src/base58.h

View Options

src/base58.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/guiutil.h

View Options

src/qt/guiutil.cpp

View Options

src/qt/receivecoinsdialog.h

View Options

src/qt/receivecoinsdialog.cpp

View Options

src/qt/receiverequestdialog.h

View Options

src/qt/receiverequestdialog.cpp

View Options

src/qt/test/guiutiltests.cpp

View Options

src/qt/test/uritests.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/qt/walletframe.h

View Options

src/qt/walletframe.cpp

View Options

src/qt/walletview.h

View Options

Only generate cashaddr URI from the GUIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10035

src/base58.h

src/base58.cpp

src/qt/bitcoingui.cpp

src/qt/guiutil.h

src/qt/guiutil.cpp

src/qt/receivecoinsdialog.h

src/qt/receivecoinsdialog.cpp

src/qt/receiverequestdialog.h

src/qt/receiverequestdialog.cpp

src/qt/test/guiutiltests.cpp

src/qt/test/uritests.cpp

src/qt/test/wallettests.cpp

src/qt/walletframe.h

src/qt/walletframe.cpp

src/qt/walletview.h

src/qt/walletview.cpp

Only generate cashaddr URI from the GUI
ClosedPublic
Actions

Revision Contents
Changeset List