Page MenuHomePhabricator
Differential D3539

Only handle cashaddr prefix in OpenURIDialog
ClosedPublic
Actions

Authored by deadalnix on Jul 3 2019, 18:27.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGd72cd1e6b3b1: Only handle cashaddr prefix in OpenURIDialog
rABCd72cd1e6b3b1: Only handle cashaddr prefix in OpenURIDialog
Summary

This allows for code simplification.

Test Plan
make src/qt/bitcoin-qt

Run bitcoin-qt on testnet. Use file, open URI and make sure the expected prefix correspond to cashaddr.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
OpenURIDialogScheme
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6655
Build 11357: Bitcoin ABC Buildbot (legacy)
Build 11356: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 3 2019, 18:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2019, 18:27
teamcity added a comment.Jul 3 2019, 18:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6655: Diff 9970.Jul 3 2019, 18:37
teamcity added a comment.Jul 3 2019, 18:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D3548: Take CChainParams explicitely in PaymentServer.Jul 4 2019, 15:58
deadalnix updated this revision to Diff 9981.Jul 4 2019, 16:10

Remove leftover header that is not required anymore

teamcity added a comment.Jul 4 2019, 16:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 4 2019, 16:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6666: Diff 9981.Jul 4 2019, 16:17
markblundeberg added a subscriber: markblundeberg.Jul 5 2019, 16:17

Looks good I think ... this should change nothing of the behaviour when run with default settings (cashaddr on), right?

markblundeberg accepted this revision.Jul 5 2019, 16:27
This revision is now accepted and ready to land.Jul 5 2019, 16:27
Closed by commit rABCd72cd1e6b3b1: Only handle cashaddr prefix in OpenURIDialog (authored by deadalnix). · Explain WhyJul 6 2019, 13:50
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCd72cd1e6b3b1: Only handle cashaddr prefix in OpenURIDialog.
deadalnix added a commit: rSTAGINGd72cd1e6b3b1: Only handle cashaddr prefix in OpenURIDialog.Sep 19 2019, 00:59

Revision Contents
Changeset List

PathSize
src/
qt/
3 lines
6 lines
15 lines

Diff 9970

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/openuridialog.h

Loading...
View Options

src/qt/openuridialog.cpp

Loading...