Page MenuHomePhabricator
Differential D3551

Default to cashaddr in most of the Qt API
ClosedPublic
Actions

Authored by deadalnix on Jul 4 2019, 19:13.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGfb3575c34274: Default to cashaddr in most of the Qt API
rABCfb3575c34274: Default to cashaddr in most of the Qt API
Summary

As per title.

Depends on D3536, D3543 and D3549

Test Plan

Run the bitcoin-qt client with usecashaddr=0 and check that most addresses are cashaddr.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
killqturischeme
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6669
Build 11385: Bitcoin ABC Buildbot (legacy)
Build 11384: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 4 2019, 19:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2019, 19:13
teamcity added a comment.Jul 4 2019, 19:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 4 2019, 19:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6669: Diff 9985.Jul 4 2019, 19:21
markblundeberg requested changes to this revision.Jul 5 2019, 16:20
markblundeberg added a subscriber: markblundeberg.

I think these changes to Qt do deserve a release note. Since this is the final one for now (it looks like) I think this Diff would be a good place for the release note to be added.

This revision now requires changes to proceed.Jul 5 2019, 16:20
deadalnix updated this revision to Diff 10036.Jul 6 2019, 15:12

Add release notes

teamcity added a comment.Jul 6 2019, 15:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 6 2019, 15:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6698: Diff 10036.Jul 6 2019, 15:23
deadalnix updated this revision to Diff 10037.Jul 6 2019, 15:58

Remove unecessary include

teamcity added a comment.Jul 6 2019, 15:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 6 2019, 16:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6699: Diff 10037.Jul 6 2019, 16:06
markblundeberg accepted this revision.Jul 6 2019, 16:26
This revision is now accepted and ready to land.Jul 6 2019, 16:26
Closed by commit rABCfb3575c34274: Default to cashaddr in most of the Qt API (authored by deadalnix). · Explain WhyJul 6 2019, 16:48
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCfb3575c34274: Default to cashaddr in most of the Qt API.
deadalnix added a commit: rSTAGINGfb3575c34274: Default to cashaddr in most of the Qt API.Sep 19 2019, 00:59

Revision Contents
Changeset List

PathSize
src/
qt/
14 lines
2 lines
12 lines
2 lines
3 lines
test/
1 line
36 lines

Diff 9985

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/paymentserver.cpp

Loading...
View Options

src/qt/sendcoinsentry.cpp

Loading...
View Options

src/qt/test/uritests.h

Loading...
View Options

src/qt/test/uritests.cpp

Loading...