Page MenuHomePhabricator

Default to cashaddr in most of the Qt API
ClosedPublic

Authored by deadalnix on Jul 4 2019, 19:13.

Details

Summary

As per title.

Depends on D3536, D3543 and D3549

Test Plan

Run the bitcoin-qt client with usecashaddr=0 and check that most addresses are cashaddr.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
killqturischeme
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6669
Build 11385: Bitcoin ABC Buildbot (legacy)
Build 11384: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 4 2019, 19:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2019, 19:13
markblundeberg requested changes to this revision.Jul 5 2019, 16:20
markblundeberg added a subscriber: markblundeberg.

I think these changes to Qt do deserve a release note. Since this is the final one for now (it looks like) I think this Diff would be a good place for the release note to be added.

This revision now requires changes to proceed.Jul 5 2019, 16:20
deadalnix updated this revision to Diff 10036.Jul 6 2019, 15:12

Add release notes

deadalnix updated this revision to Diff 10037.Jul 6 2019, 15:58

Remove unecessary include

markblundeberg accepted this revision.Jul 6 2019, 16:26
This revision is now accepted and ready to land.Jul 6 2019, 16:26
This revision was automatically updated to reflect the committed changes.