Move utility functions in feature_csv_activation.py out of class.
ClosedPublic
Actions

Authored by Fabien on Jul 5 2019, 12:25.

Details

Reviewers

deadalnix
markblundeberg

Group Reviewers

Restricted Project

Maniphest Tasks

T669: Removing comparison test framework

Commits

rSTAGINGaae5372964bc: Move utility functions in feature_csv_activation.py out of class.
rABCaae5372964bc: Move utility functions in feature_csv_activation.py out of class.

Summary

Partial backport of core PR11817 (commit db7ffb9)
https://github.com/bitcoin/bitcoin/pull/11817/commits/db7ffb9d1b9dbdf19b49cc397a7d5e31db244214

Depends on D3559

Test Plan

./test/functional/test_runner.py feature_csv_activation

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11817_part3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6679
Build 11405: Bitcoin ABC Buildbot (legacy)
Build 11404: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 5 2019, 12:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 12:25

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6679: Diff 9995.Jul 5 2019, 12:31

Fabien added a child revision: D3561: [tests] Change feature_csv_activation.py to use BitcoinTestFramework.Jul 5 2019, 12:35

markblundeberg added a task: T669: Removing comparison test framework.Jul 5 2019, 12:56

markblundeberg accepted this revision.Jul 5 2019, 13:20

This revision is now accepted and ready to land.Jul 5 2019, 13:20

Closed by commit rABCaae5372964bc: Move utility functions in feature_csv_activation.py out of class. (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJul 5 2019, 13:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCaae5372964bc: Move utility functions in feature_csv_activation.py out of class..

Fabien added a commit: rSTAGINGaae5372964bc: Move utility functions in feature_csv_activation.py out of class..Sep 19 2019, 00:56

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_csv_activation.py

273 lines

Diff 9995

View Options

test/functional/feature_csv_activation.py

Move utility functions in feature_csv_activation.py out of class.ClosedPublicActions